Commit Graph

2151 Commits

Author SHA1 Message Date
b8354be347 encode echo output to utf8 2018-07-07 12:04:04 +00:00
63014bd809 string.decode instead of unicode.decode 2018-07-07 11:57:46 +00:00
afc2ddb3e3 revert format string 2018-07-07 11:56:11 +00:00
d410971e52 move encoding to transport 2018-07-07 08:03:19 +00:00
28b6f6e7a7 format needs {} 2018-07-06 23:24:12 +00:00
2dff11e678 add comment on version strings 2018-07-06 23:02:06 +00:00
bd9b528b99 flake8 warnings 2018-07-06 22:49:24 +00:00
1d38c45ee1 typo 2018-07-06 22:40:32 +00:00
349a115000 no longer need this. use environment variables 2018-07-06 22:38:50 +00:00
1d1c138a62 get test framework workign with environment variables 2018-07-06 22:38:24 +00:00
bd2c5b242f flake8 errors/warnings 2018-07-06 22:07:43 +00:00
deaec9f550 prompt was broken 2018-07-06 21:53:45 +00:00
ab3e5fb7d5 Fix F401 W391 2018-07-06 21:45:09 +00:00
16b44d519b pickle file has moved. update tests 2018-07-06 21:33:03 +00:00
2a8f13976e Use OrderedDict to prevent reordering. (#802) 2018-07-06 22:35:29 +04:00
f777eb7e47 Merge branch 'master' of https://github.com/micheloosterhof/cowrie 2018-07-05 19:13:40 +00:00
886e42f903 duplicte use of cowrie.client.fingerprint. Rename to cowrie.client.kex 2018-07-05 19:13:15 +00:00
170ce3d5e3 Fixing flake8 E2 (#796)
* flake8 E2 cowrie/insults/insults.py

flake8 --count --select=E1,E2 --statistics cowrie/insults/insults.py
cowrie/insults/insults.py:51:28: E261 at least two spaces before inline comment
cowrie/insults/insults.py:53:28: E261 at least two spaces before inline comment
cowrie/insults/insults.py:86:14: E261 at least two spaces before inline comment
cowrie/insults/insults.py:86:15: E262 inline comment should start with '# '
cowrie/insults/insults.py:115:13: E265 block comment should start with '# '
cowrie/insults/insults.py:181:47: E226 missing whitespace around arithmetic operator
cowrie/insults/insults.py:215:41: E226 missing whitespace around arithmetic operator
2     E226 missing whitespace around arithmetic operator
3     E261 at least two spaces before inline comment
1     E262 inline comment should start with '# '
1     E265 block comment should start with '# '
7

* flake8 E2  cowrie/telnet/session.py

flake8 --count --select=E1,E2 --statistics cowrie/telnet/session.py
cowrie/telnet/session.py:28:11: E261 at least two spaces before inline comment
cowrie/telnet/session.py:116:5: E265 block comment should start with '# '
1     E261 at least two spaces before inline comment
1     E265 block comment should start with '# '
2

* flake8 E2 cowrie/telnet/transport.py

flake8 --count --select=E1,E2 --statistics cowrie/telnet/transport.py
cowrie/telnet/transport.py:36:32: E226 missing whitespace around arithmetic operator
cowrie/telnet/transport.py:108:9: E265 block comment should start with '# '
cowrie/telnet/transport.py:144:53: E226 missing whitespace around arithmetic operator
cowrie/telnet/transport.py:197:13: E265 block comment should start with '# '
cowrie/telnet/transport.py:207:13: E265 block comment should start with '# '
cowrie/telnet/transport.py:208:13: E265 block comment should start with '# '
cowrie/telnet/transport.py:237:30: E226 missing whitespace around arithmetic operator
3     E226 missing whitespace around arithmetic operator
4     E265 block comment should start with '# '
7

* flake8 E2 cowrie/dblog/xmpp.py

 lake8 --count --select=E1,E2 --statistics cowrie/dblog/xmpp.py
cowrie/dblog/xmpp.py:20:20: E221 multiple spaces before operator
cowrie/dblog/xmpp.py:25:18: E221 multiple spaces before operator
cowrie/dblog/xmpp.py:26:18: E221 multiple spaces before operator
cowrie/dblog/xmpp.py:38:29: E202 whitespace before ')'
cowrie/dblog/xmpp.py:44:32: E202 whitespace before ')'
cowrie/dblog/xmpp.py:66:15: E221 multiple spaces before operator
cowrie/dblog/xmpp.py:67:13: E221 multiple spaces before operator
cowrie/dblog/xmpp.py:68:17: E221 multiple spaces before operator
cowrie/dblog/xmpp.py:69:12: E221 multiple spaces before operator
cowrie/dblog/xmpp.py:81:54: E231 missing whitespace after ','
cowrie/dblog/xmpp.py:81:59: E231 missing whitespace after ','
cowrie/dblog/xmpp.py:81:66: E231 missing whitespace after ','
cowrie/dblog/xmpp.py:88:46: E261 at least two spaces before inline comment
cowrie/dblog/xmpp.py:103:84: E203 whitespace before ','
cowrie/dblog/xmpp.py:109:33: E231 missing whitespace after ','
cowrie/dblog/xmpp.py:161:21: E221 multiple spaces before operator
2     E202 whitespace before ')'
1     E203 whitespace before ','
8     E221 multiple spaces before operator
4     E231 missing whitespace after ','
1     E261 at least two spaces before inline comment
16

* flake8 E2 cowrie/commands/ping.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/ping.py
cowrie/commands/ping.py:57:21: E225 missing whitespace around operator
cowrie/commands/ping.py:64:29: E226 missing whitespace around arithmetic operator
1     E225 missing whitespace around operator
1     E226 missing whitespace around arithmetic operator
2

* flake8 E2 cowrie/commands/base.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/base.py
./cowrie/commands/base.py:29:47: E226 missing whitespace around arithmetic operator
./cowrie/commands/base.py:115:45: E231 missing whitespace after ','
./cowrie/commands/base.py:246:46: E226 missing whitespace around arithmetic operator
./cowrie/commands/base.py:313:25: E226 missing whitespace around arithmetic operator
./cowrie/commands/base.py:402:29: E226 missing whitespace around arithmetic operator
./cowrie/commands/base.py:495:61: E226 missing whitespace around arithmetic operator
./cowrie/commands/base.py:511:43: E226 missing whitespace around arithmetic operator
./cowrie/commands/base.py:596:29: E226 missing whitespace around arithmetic operator
./cowrie/commands/base.py:640:29: E226 missing whitespace around arithmetic operator
8     E226 missing whitespace around arithmetic operator
1     E231 missing whitespace after ','
9

* flake8 E2 setup.py

flake8 --count --select=E1,E2 --statistics setup.py
./setup.py:5:6: E211 whitespace before '('
./setup.py:6:9: E251 unexpected spaces around keyword / parameter equals
./setup.py:6:9: E221 multiple spaces before operator
./setup.py:6:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:7:12: E251 unexpected spaces around keyword / parameter equals
./setup.py:7:12: E221 multiple spaces before operator
./setup.py:7:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:8:16: E251 unexpected spaces around keyword / parameter equals
./setup.py:8:16: E221 multiple spaces before operator
./setup.py:8:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:9:15: E251 unexpected spaces around keyword / parameter equals
./setup.py:9:15: E221 multiple spaces before operator
./setup.py:9:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:10:21: E251 unexpected spaces around keyword / parameter equals
./setup.py:10:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:11:13: E251 unexpected spaces around keyword / parameter equals
./setup.py:11:13: E221 multiple spaces before operator
./setup.py:11:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:12:8: E251 unexpected spaces around keyword / parameter equals
./setup.py:12:8: E221 multiple spaces before operator
./setup.py:12:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:13:13: E251 unexpected spaces around keyword / parameter equals
./setup.py:13:13: E221 multiple spaces before operator
./setup.py:13:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:15:17: E251 unexpected spaces around keyword / parameter equals
./setup.py:15:17: E221 multiple spaces before operator
./setup.py:15:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:15:25: E201 whitespace after '{'
./setup.py:15:38: E202 whitespace before '}'
./setup.py:16:12: E251 unexpected spaces around keyword / parameter equals
./setup.py:16:12: E221 multiple spaces before operator
./setup.py:16:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:21:21: E251 unexpected spaces around keyword / parameter equals
./setup.py:21:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:35:17: E251 unexpected spaces around keyword / parameter equals
./setup.py:35:17: E221 multiple spaces before operator
./setup.py:35:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:38:19: E251 unexpected spaces around keyword / parameter equals
./setup.py:38:19: E221 multiple spaces before operator
./setup.py:38:23: E251 unexpected spaces around keyword / parameter equals
./setup.py:38:25: E201 whitespace after '{'
1     E127 continuation line over-indented for visual indent
1     E201 whitespace after '{'
1     E202 whitespace before '}'
1     E211 whitespace before '('
26    E251 unexpected spaces around keyword / parameter equals
30

* flake8 E2 cowrie/shell/protocol.py

flake8 --count --select=E1,E2 --statistics cowrie/shell/protocol.py
cowrie/shell/protocol.py:63:119: E231 missing whitespace after ','
cowrie/shell/protocol.py:63:129: E231 missing whitespace after ','
cowrie/shell/protocol.py:139:29: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:146:9: E265 block comment should start with '# '
cowrie/shell/protocol.py:231:9: E265 block comment should start with '# '
cowrie/shell/protocol.py:309:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:309:43: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:310:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:310:43: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:311:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:311:45: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:312:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:312:45: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:313:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:313:42: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:314:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:314:44: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:315:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:315:48: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:316:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:317:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:317:45: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:318:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:318:45: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:319:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:319:43: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:320:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:320:41: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:321:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:321:45: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:322:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:322:45: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:323:21: E241 multiple spaces after ':'
cowrie/shell/protocol.py:323:42: E261 at least two spaces before inline comment
cowrie/shell/protocol.py:331:67: E226 missing whitespace around arithmetic operator
cowrie/shell/protocol.py:375:70: E226 missing whitespace around arithmetic operator
2     E226 missing whitespace around arithmetic operator
2     E231 missing whitespace after ','
15    E241 multiple spaces after ':'
15    E261 at least two spaces before inline comment
2     E265 block comment should start with '# '
36

* flake8 E2 cowrie/commands/scp.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/scp.py
cowrie/commands/scp.py:235:48: E226 missing whitespace around arithmetic operator
1     E226 missing whitespace around arithmetic operator
1

* flake8 E2 cowrie/commands/ifconfig.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/ifconfig.py
cowrie/commands/ifconfig.py:34:21: E226 missing whitespace around arithmetic operator
1     E226 missing whitespace around arithmetic operator
1

* flake8 E2 cowrie/commands/ssh.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/ssh.py
cowrie/commands/ssh.py:58:29: E226 missing whitespace around arithmetic operator
1     E226 missing whitespace around arithmetic operator
1

* flake8 E2 cowrie/commands/iptables.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/iptables.py
cowrie/commands/iptables.py:69:28: E231 missing whitespace after ','
cowrie/commands/iptables.py:69:36: E231 missing whitespace after ','
cowrie/commands/iptables.py:69:42: E231 missing whitespace after ','
cowrie/commands/iptables.py:71:24: E225 missing whitespace around operator
cowrie/commands/iptables.py:74:24: E225 missing whitespace around operator
cowrie/commands/iptables.py:75:38: E231 missing whitespace after ','
cowrie/commands/iptables.py:75:50: E231 missing whitespace after ','
cowrie/commands/iptables.py:320:41: E226 missing whitespace around arithmetic operator
cowrie/commands/iptables.py:359:43: E226 missing whitespace around arithmetic operator
2     E225 missing whitespace around operator
2     E226 missing whitespace around arithmetic operator
5     E231 missing whitespace after ','
9

* flake8 E2 cowrie/commands/python.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/python.py
cowrie/commands/python.py:83:45: E222 multiple spaces after operator
1     E222 multiple spaces after operator
1

* flake8 E2 cowrie/commands/apt.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/apt.py
cowrie/commands/apt.py:42:32: E251 unexpected spaces around keyword / parameter equals
cowrie/commands/apt.py:42:34: E251 unexpected spaces around keyword / parameter equals
cowrie/commands/apt.py:113:24: E231 missing whitespace after ','
cowrie/commands/apt.py:115:112: E231 missing whitespace after ','
cowrie/commands/apt.py:122:27: E241 multiple spaces after ':'
cowrie/commands/apt.py:126:24: E241 multiple spaces after ':'
2     E231 missing whitespace after ','
2     E241 multiple spaces after ':'
2     E251 unexpected spaces around keyword / parameter equals
6

* flake8 E2 cowrie/commands/fs.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/fs.py
cowrie/commands/fs.py:36:35: E231 missing whitespace after ','
cowrie/commands/fs.py:45:20: E201 whitespace after '('
cowrie/commands/fs.py:46:20: E201 whitespace after '('
cowrie/commands/fs.py:47:20: E201 whitespace after '('
cowrie/commands/fs.py:48:20: E201 whitespace after '('
4     E201 whitespace after '('
1     E231 missing whitespace after ','
5

* flake8 E2 cowrie/commands/gcc.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/gcc.py
cowrie/commands/gcc.py:21:13: E221 multiple spaces before operator
cowrie/commands/gcc.py:166:24: E226 missing whitespace around arithmetic operator
1     E221 multiple spaces before operator
1     E226 missing whitespace around arithmetic operator
2

* flake8 E2 cowrie/commands/last.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/last.py
cowrie/commands/last.py:30:48: E231 missing whitespace after ','
cowrie/commands/last.py:36:81: E226 missing whitespace around arithmetic operator
cowrie/commands/last.py:36:93: E226 missing whitespace around arithmetic operator
cowrie/commands/last.py:36:102: E202 whitespace before ')'
cowrie/commands/last.py:36:105: E202 whitespace before ')'
2     E202 whitespace before ')'
2     E226 missing whitespace around arithmetic operator
1     E231 missing whitespace after ','
5

* flake8 E2 cowrie/commands/busybox.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/busybox.py
cowrie/commands/busybox.py:6:50: E231 missing whitespace after ','
cowrie/commands/busybox.py:11:13: E225 missing whitespace around operator
cowrie/commands/busybox.py:62:31: E226 missing whitespace around arithmetic operator
1     E225 missing whitespace around operator
1     E226 missing whitespace around arithmetic operator
1     E231 missing whitespace after ','
3

* flake8 E2 cowrie/commands/netstat.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/netstat.py
cowrie/commands/netstat.py:75:22: E226 missing whitespace around arithmetic operator
cowrie/commands/netstat.py:76:22: E226 missing whitespace around arithmetic operator
cowrie/commands/netstat.py:97:37: E226 missing whitespace around arithmetic operator
cowrie/commands/netstat.py:97:41: E226 missing whitespace around arithmetic operator
cowrie/commands/netstat.py:97:52: E226 missing whitespace around arithmetic operator
cowrie/commands/netstat.py:97:60: E226 missing whitespace around arithmetic operator
cowrie/commands/netstat.py:98:37: E226 missing whitespace around arithmetic operator
cowrie/commands/netstat.py:98:41: E226 missing whitespace around arithmetic operator
cowrie/commands/netstat.py:98:52: E226 missing whitespace around arithmetic operator
cowrie/commands/netstat.py:98:60: E226 missing whitespace around arithmetic operator
cowrie/commands/netstat.py💯25: E226 missing whitespace around arithmetic operator
11    E226 missing whitespace around arithmetic operator
11

* flake8 E2 cowrie/commands/free.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/free.py
cowrie/commands/free.py:16:11: E225 missing whitespace around operator
cowrie/commands/free.py:21:10: E225 missing whitespace around operator
cowrie/commands/free.py:26:11: E225 missing whitespace around operator
cowrie/commands/free.py:60:15: E225 missing whitespace around operator
cowrie/commands/free.py:61:34: E226 missing whitespace around arithmetic operator
cowrie/commands/free.py:62:17: E225 missing whitespace around operator
cowrie/commands/free.py:63:33: E226 missing whitespace around arithmetic operator
cowrie/commands/free.py:64:17: E225 missing whitespace around operator
cowrie/commands/free.py:65:34: E226 missing whitespace around arithmetic operator
6     E225 missing whitespace around operator
3     E226 missing whitespace around arithmetic operator
9

* flake8 E2 cowrie/commands/ls.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/ls.py
cowrie/commands/ls.py:189:25: E226 missing whitespace around arithmetic operator
1     E226 missing whitespace around arithmetic operator
1

* flake8 E2 cowrie/commands/cat.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/cat.py
cowrie/commands/cat.py:79:28: E226 missing whitespace around arithmetic operator
1     E226 missing whitespace around arithmetic operator
1

* flake8 E2 cowrie/commands/tar.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/tar.py
cowrie/commands/tar.py:75:34: E226 missing whitespace around arithmetic operator
1     E226 missing whitespace around arithmetic operator
1

* flake8 E2 cowrie/commands/sudo.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/sudo.py
cowrie/commands/sudo.py:9:50: E231 missing whitespace after ','
cowrie/commands/sudo.py:13:15: E225 missing whitespace around operator
cowrie/commands/sudo.py:22:14: E225 missing whitespace around operator
cowrie/commands/sudo.py:66:31: E226 missing whitespace around arithmetic operator
cowrie/commands/sudo.py:74:31: E226 missing whitespace around arithmetic operator
cowrie/commands/sudo.py:95:29: E231 missing whitespace after ','
cowrie/commands/sudo.py:96:26: E222 multiple spaces after operator
cowrie/commands/sudo.py:101:45: E231 missing whitespace after ','
cowrie/commands/sudo.py:125:17: E265 block comment should start with '# '
cowrie/commands/sudo.py:128:70: E231 missing whitespace after ','
cowrie/commands/sudo.py:128:79: E231 missing whitespace after ','
cowrie/commands/sudo.py:128:106: E203 whitespace before ','
cowrie/commands/sudo.py:128:107: E231 missing whitespace after ','
1     E203 whitespace before ','
1     E222 multiple spaces after operator
2     E225 missing whitespace around operator
2     E226 missing whitespace around arithmetic operator
6     E231 missing whitespace after ','
1     E265 block comment should start with '# '
13

* flake8 E2 cowrie/commands/env.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/env.py
cowrie/commands/env.py:41:39: E231 missing whitespace after ','
1     E231 missing whitespace after ','
1

* flake8 E2 cowrie/commands/curl.py

flake8 --count --select=E1,E2 --statistics cowrie/commands/curl.py
cowrie/commands/curl.py:85:12: E225 missing whitespace around operator
cowrie/commands/curl.py:294:14: E261 at least two spaces before inline comment
cowrie/commands/curl.py:349:46: E261 at least two spaces before inline comment
cowrie/commands/curl.py:351:25: E226 missing whitespace around arithmetic operator
cowrie/commands/curl.py:383:30: E261 at least two spaces before inline comment
cowrie/commands/curl.py:437:46: E226 missing whitespace around arithmetic operator
cowrie/commands/curl.py:437:64: E226 missing whitespace around arithmetic operator
cowrie/commands/curl.py:440:55: E226 missing whitespace around arithmetic operator
cowrie/commands/curl.py:464:41: E226 missing whitespace around arithmetic operator
1     E225 missing whitespace around operator
5     E226 missing whitespace around arithmetic operator
3     E261 at least two spaces before inline comment
9

* flake8 E2 cowrie/ssh/factory.py

flake8 --count --select=E1,E2 --statistics cowrie/ssh/factory.py
cowrie/ssh/factory.py:39:15: E261 at least two spaces before inline comment
cowrie/ssh/factory.py:45:32: E226 missing whitespace around arithmetic operator
1     E226 missing whitespace around arithmetic operator
1     E261 at least two spaces before inline comment
2

* flake8 E2 cowrie/ssh/session.py

flake8 --count --select=E1,E2 --statistics cowrie/ssh/session.py
cowrie/ssh/session.py:22:9: E265 block comment should start with '# '
1     E265 block comment should start with '# '
1

* flake8 E2 cowrie/ssh/channel.py

flake8 --count --select=E1,E2 --statistics cowrie/ssh/channel.py
cowrie/ssh/channel.py:81:40: E226 missing whitespace around arithmetic operator
cowrie/ssh/channel.py:82:37: E226 missing whitespace around arithmetic operator
2     E226 missing whitespace around arithmetic operator
2

* flake8 E2 cowrie/ssh/userauth.py

flake8 --count --select=E1,E2 --statistics cowrie/ssh/userauth.py
cowrie/ssh/userauth.py:133:26: E261 at least two spaces before inline comment
cowrie/ssh/userauth.py:135:28: E261 at least two spaces before inline comment
2     E261 at least two spaces before inline comment
2

* flake8 E2 cowrie/ssh/transport.py

flake8 --count --select=E1,E2 --statistics cowrie/ssh/transport.py
cowrie/ssh/transport.py:59:56: E226 missing whitespace around arithmetic operator
cowrie/ssh/transport.py:61:33: E226 missing whitespace around arithmetic operator
cowrie/ssh/transport.py:61:55: E226 missing whitespace around arithmetic operator
cowrie/ssh/transport.py:96:13: E265 block comment should start with '# '
cowrie/ssh/transport.py:107:38: E226 missing whitespace around arithmetic operator
4     E226 missing whitespace around arithmetic operator
1     E265 block comment should start with '# '
5

* flake8 E2 cowrie/output/mysql.py

flake8 --count --select=E1,E2 --statistics cowrie/output/mysql.py
cowrie/output/mysql.py:37:72: E225 missing whitespace around operator
cowrie/output/mysql.py:74:21: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:74:23: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:75:19: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:75:21: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:76:21: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:76:23: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:77:23: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:77:25: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:78:21: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:78:23: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:79:23: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:79:25: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:80:23: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:80:25: E251 unexpected spaces around keyword / parameter equals
cowrie/output/mysql.py:128:18: E222 multiple spaces after operator
1     E222 multiple spaces after operator
1     E225 missing whitespace around operator
14    E251 unexpected spaces around keyword / parameter equals
16

* flake8 E2 cowrie/output/hpfeeds3.py

flake8 --count --select=E1,E2 --statistics cowrie/output/hpfeeds3.py
cowrie/output/hpfeeds3.py:68:26: E231 missing whitespace after ':'
cowrie/output/hpfeeds3.py:70:26: E231 missing whitespace after ':'
cowrie/output/hpfeeds3.py:76:30: E231 missing whitespace after ':'
cowrie/output/hpfeeds3.py:77:27: E231 missing whitespace after ':'
cowrie/output/hpfeeds3.py:78:34: E231 missing whitespace after ':'
cowrie/output/hpfeeds3.py:79:23: E231 missing whitespace after ':'
6     E231 missing whitespace after ':'
6

* flake8 E2 cowrie/output/textlog.py

flake8 --count --select=E1,E2 --statistics cowrie/output/textlog.py
cowrie/output/textlog.py:63:53: E226 missing whitespace around arithmetic operator
cowrie/output/textlog.py:64:67: E226 missing whitespace around arithmetic operator
cowrie/output/textlog.py:66:53: E226 missing whitespace around arithmetic operator
cowrie/output/textlog.py:67:51: E226 missing whitespace around arithmetic operator
4     E226 missing whitespace around arithmetic operator
4

* flake8 E2 cowrie/output/sqlite.py

flake8 --count --select=E1,E2 --statistics cowrie/output/sqlite.py
cowrie/output/sqlite.py:36:25: E251 unexpected spaces around keyword / parameter equals
cowrie/output/sqlite.py:36:27: E251 unexpected spaces around keyword / parameter equals
cowrie/output/sqlite.py:86:18: E222 multiple spaces after operator
1     E222 multiple spaces after operator
2     E251 unexpected spaces around keyword / parameter equals
3

* flake8 E2 cowrie/output/hpfeeds.py

flake8 --count --select=E1,E2 --statistics cowrie/output/hpfeeds.py
cowrie/output/hpfeeds.py:33:9: E221 multiple spaces before operator
cowrie/output/hpfeeds.py:34:8: E221 multiple spaces before operator
cowrie/output/hpfeeds.py:35:8: E221 multiple spaces before operator
cowrie/output/hpfeeds.py:36:11: E221 multiple spaces before operator
cowrie/output/hpfeeds.py:37:13: E221 multiple spaces before operator
cowrie/output/hpfeeds.py:41:16: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:42:15: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:42:19: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:43:15: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:43:19: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:44:18: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:45:20: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:45:24: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:73:17: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:73:25: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:78:32: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:94:36: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:127:48: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:248:37: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:248:48: E226 missing whitespace around arithmetic operator
cowrie/output/hpfeeds.py:300:26: E231 missing whitespace after ':'
cowrie/output/hpfeeds.py:302:26: E231 missing whitespace after ':'
cowrie/output/hpfeeds.py:308:30: E231 missing whitespace after ':'
cowrie/output/hpfeeds.py:309:27: E231 missing whitespace after ':'
cowrie/output/hpfeeds.py:310:34: E231 missing whitespace after ':'
cowrie/output/hpfeeds.py:311:23: E231 missing whitespace after ':'
5     E221 multiple spaces before operator
15    E226 missing whitespace around arithmetic operator
6     E231 missing whitespace after ':'
26

* flake8 E2 cowrie/output/influx.py

flake8 --count --select=E1,E2 --statistics cowrie/output/influx.py
cowrie/output/influx.py:109:47: E231 missing whitespace after ','
1     E231 missing whitespace after ','
1

* flake8 E2 cowrie/output/virustotal.py

flake8 --count --select=E1,E2 --statistics cowrie/output/virustotal.py
cowrie/output/virustotal.py:93:13: E265 block comment should start with '# '
cowrie/output/virustotal.py:94:13: E265 block comment should start with '# '
cowrie/output/virustotal.py:95:13: E265 block comment should start with '# '
cowrie/output/virustotal.py:104:13: E265 block comment should start with '# '
cowrie/output/virustotal.py:105:13: E265 block comment should start with '# '
cowrie/output/virustotal.py:113:26: E226 missing whitespace around arithmetic operator
cowrie/output/virustotal.py:126:17: E265 block comment should start with '# '
cowrie/output/virustotal.py:180:17: E265 block comment should start with '# '
cowrie/output/virustotal.py:193:26: E226 missing whitespace around arithmetic operator
cowrie/output/virustotal.py:197:41: E226 missing whitespace around arithmetic operator
cowrie/output/virustotal.py:261:26: E226 missing whitespace around arithmetic operator
cowrie/output/virustotal.py:274:17: E265 block comment should start with '# '
cowrie/output/virustotal.py:329:26: E226 missing whitespace around arithmetic operator
cowrie/output/virustotal.py:330:23: E201 whitespace after '{'
1     E201 whitespace after '{'
5     E226 missing whitespace around arithmetic operator
8     E265 block comment should start with '# '
14

* flake8 E2 cowrie/output/jsonlog.py

flake8 --count --select=E1,E2 --statistics cowrie/output/jsonlog.py
cowrie/output/jsonlog.py:73:59: E225 missing whitespace around operator
1     E225 missing whitespace around operator
1

* flake8 E2 cowrie/output/dshield.py

flake8 --count --select=E1,E2 --statistics cowrie/output/dshield.py
cowrie/output/dshield.py:39:24: E261 at least two spaces before inline comment
cowrie/output/dshield.py:50:23: E203 whitespace before ':'
cowrie/output/dshield.py:51:23: E203 whitespace before ':'
cowrie/output/dshield.py:52:27: E203 whitespace before ':'
cowrie/output/dshield.py:53:28: E203 whitespace before ':'
cowrie/output/dshield.py:54:23: E203 whitespace before ':'
cowrie/output/dshield.py:55:27: E203 whitespace before ':'
cowrie/output/dshield.py:102:27: E231 missing whitespace after ':'
cowrie/output/dshield.py:104:9: E265 block comment should start with '# '
cowrie/output/dshield.py:111:19: E251 unexpected spaces around keyword / parameter equals
cowrie/output/dshield.py:112:16: E251 unexpected spaces around keyword / parameter equals
cowrie/output/dshield.py:112:18: E251 unexpected spaces around keyword / parameter equals
cowrie/output/dshield.py:113:20: E251 unexpected spaces around keyword / parameter equals
cowrie/output/dshield.py:113:22: E251 unexpected spaces around keyword / parameter equals
cowrie/output/dshield.py:114:20: E251 unexpected spaces around keyword / parameter equals
cowrie/output/dshield.py:114:22: E251 unexpected spaces around keyword / parameter equals
cowrie/output/dshield.py:115:17: E251 unexpected spaces around keyword / parameter equals
cowrie/output/dshield.py:115:19: E251 unexpected spaces around keyword / parameter equals
cowrie/output/dshield.py:132:57: E226 missing whitespace around arithmetic operator
6     E203 whitespace before ':'
1     E226 missing whitespace around arithmetic operator
1     E231 missing whitespace after ':'
9     E251 unexpected spaces around keyword / parameter equals
1     E261 at least two spaces before inline comment
1     E265 block comment should start with '# '
19

* flake8 E2 cowrie/output/elasticsearch.py

flake8 --count --select=E1,E2 --statistics cowrie/output/elasticsearch.py
cowrie/output/elasticsearch.py:22:21: E225 missing whitespace around operator
1     E225 missing whitespace around operator
1flake8 E2 cowrie/output/elasticsearch.py

flake8 --count --select=E1,E2 --statistics
cowrie/output/elasticsearch.py
cowrie/output/elasticsearch.py:22:21: E225 missing whitespace around
operator
1     E225 missing whitespace around operator
1flake8 E2 cowrie/output/elasticsearch.py

flake8 --count --select=E1,E2 --statistics
cowrie/output/elasticsearch.py
cowrie/output/elasticsearch.py:22:21: E225 missing whitespace around
operator
1     E225 missing whitespace around operator
1flake8 E2 cowrie/output/elasticsearch.py

flake8 --count --select=E1,E2 --statistics
cowrie/output/elasticsearch.py
cowrie/output/elasticsearch.py:22:21: E225 missing whitespace around
operator
1     E225 missing whitespace around operator
1flake8 E2 cowrie/output/elasticsearch.py

flake8 --count --select=E1,E2 --statistics
cowrie/output/elasticsearch.py
cowrie/output/elasticsearch.py:22:21: E225 missing whitespace around
operator
1     E225 missing whitespace around operator
1flake8 E2 cowrie/output/elasticsearch.py

flake8 --count --select=E1,E2 --statistics
cowrie/output/elasticsearch.py
cowrie/output/elasticsearch.py:22:21: E225 missing whitespace around
operator
1     E225 missing whitespace around operator
1flake8 E2 cowrie/output/elasticsearch.py

flake8 --count --select=E1,E2 --statistics
cowrie/output/elasticsearch.py
cowrie/output/elasticsearch.py:22:21: E225 missing whitespace around
operator
1     E225 missing whitespace around operator
1flake8 E2 cowrie/output/elasticsearch.py

flake8 --count --select=E1,E2 --statistics
cowrie/output/elasticsearch.py
cowrie/output/elasticsearch.py:22:21: E225 missing whitespace around
operator
1     E225 missing whitespace around operator
1

* flake8 E2 cowrie/output/xmpp.py

flake8 --count --select=E1,E2 --statistics cowrie/output/xmpp.py
cowrie/output/xmpp.py:19:20: E221 multiple spaces before operator
cowrie/output/xmpp.py:24:18: E221 multiple spaces before operator
cowrie/output/xmpp.py:25:18: E221 multiple spaces before operator
cowrie/output/xmpp.py:71:15: E221 multiple spaces before operator
cowrie/output/xmpp.py:72:13: E221 multiple spaces before operator
cowrie/output/xmpp.py:72:21: E222 multiple spaces after operator
cowrie/output/xmpp.py:73:17: E221 multiple spaces before operator
cowrie/output/xmpp.py:74:12: E221 multiple spaces before operator
cowrie/output/xmpp.py:79:44: E231 missing whitespace after ','
cowrie/output/xmpp.py:79:53: E231 missing whitespace after ','
cowrie/output/xmpp.py:79:58: E231 missing whitespace after ','
cowrie/output/xmpp.py:79:65: E231 missing whitespace after ','
cowrie/output/xmpp.py:86:46: E261 at least two spaces before inline comment
cowrie/output/xmpp.py:102:38: E231 missing whitespace after ','
7     E221 multiple spaces before operator
1     E222 multiple spaces after operator
5     E231 missing whitespace after ','
1     E261 at least two spaces before inline comment
14

* flake8 E2 cowrie/shell/honeypot.py

flake8 --count --select=E1,E2 --statistics cowrie/shell/honeypot.py
cowrie/shell/honeypot.py:210:9: E265 block comment should start with '# '
cowrie/shell/honeypot.py:347:32: E226 missing whitespace around arithmetic operator
cowrie/shell/honeypot.py:365:43: E226 missing whitespace around arithmetic operator
cowrie/shell/honeypot.py:366:29: E222 multiple spaces after operator
cowrie/shell/honeypot.py:397:33: E226 missing whitespace around arithmetic operator
cowrie/shell/honeypot.py:398:30: E226 missing whitespace around arithmetic operator
cowrie/shell/honeypot.py:402:9: E265 block comment should start with '# '
cowrie/shell/honeypot.py:403:9: E265 block comment should start with '# '
cowrie/shell/honeypot.py:408:45: E226 missing whitespace around arithmetic operator
cowrie/shell/honeypot.py:408:49: E226 missing whitespace around arithmetic operator
cowrie/shell/honeypot.py:408:72: E226 missing whitespace around arithmetic operator
cowrie/shell/honeypot.py:408:76: E226 missing whitespace around arithmetic operator
cowrie/shell/honeypot.py:414:35: E203 whitespace before ','
cowrie/shell/honeypot.py:440:19: E222 multiple spaces after operator
1     E203 whitespace before ','
2     E222 multiple spaces after operator
8     E226 missing whitespace around arithmetic operator
3     E265 block comment should start with '# '
14

* flake8 E2 cowrie/shell/fs.py

flake8 --count --select=E1,E2 --statistics cowrie/shell/fs.py
cowrie/shell/fs.py:229:63: E225 missing whitespace around operator
cowrie/shell/fs.py:377:13: E265 block comment should start with '# '
cowrie/shell/fs.py:416:13: E265 block comment should start with '# '
cowrie/shell/fs.py:457:36: E225 missing whitespace around operator
cowrie/shell/fs.py:558:23: E231 missing whitespace after ':'
cowrie/shell/fs.py:559:22: E231 missing whitespace after ':'
cowrie/shell/fs.py:560:22: E231 missing whitespace after ':'
cowrie/shell/fs.py:561:23: E231 missing whitespace after ':'
cowrie/shell/fs.py:562:23: E231 missing whitespace after ':'
cowrie/shell/fs.py:563:24: E231 missing whitespace after ':'
2     E225 missing whitespace around operator
6     E231 missing whitespace after ':'
2     E265 block comment should start with '# '
10

* flake8 E2 cowrie/shell/shlex.py

flake8 --count --select=E1,E2 --statistics cowrie/shell/shlex.py
cowrie/shell/shlex.py:70:13: E265 block comment should start with '# '
cowrie/shell/shlex.py:321:1: E265 block comment should start with '# '
2     E265 block comment should start with '# '
2

* flake8 E2 cowrie/shell/filetransfer.py

flake8 --count --select=E1,E2 --statistics cowrie/shell/filetransfer.py
cowrie/shell/filetransfer.py:83:43: E226 missing whitespace around arithmetic operator
cowrie/shell/filetransfer.py:116:33: E226 missing whitespace around arithmetic operator
cowrie/shell/filetransfer.py:309:9: E265 block comment should start with '# '
2     E226 missing whitespace around arithmetic operator
1     E265 block comment should start with '# '
3

* flake8 E2 cowrie/shell/session.py

flake8 --count --select=E1,E2 --statistics cowrie/shell/session.py
cowrie/shell/session.py:47:20: E225 missing whitespace around operator
cowrie/shell/session.py:48:33: E225 missing whitespace around operator
cowrie/shell/session.py:50:33: E225 missing whitespace around operator
3     E225 missing whitespace around operator
3

* flake8 E2 cowrie/shell/customparser.py

flake8 --count --select=E1,E2 --statistics cowrie/shell/customparser.py
cowrie/shell/customparser.py:56:27: E231 missing whitespace after ','
1     E231 missing whitespace after ','
1

* flake8 E2 cowrie/test/test_base_commands.py

flake8 --count --select=E1,E2 --statistics cowrie/test/test_base_commands.py
cowrie/test/test_base_commands.py:24:58: E211 whitespace before '('
cowrie/test/test_base_commands.py:33:41: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:38:41: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:43:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:47:49: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:52:49: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:57:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:74:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:83:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:87:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:94:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:114:49: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:123:49: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:134:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:139:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:144:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:149:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:154:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:159:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:164:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:169:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:174:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:179:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:184:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:189:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:193:42: E231 missing whitespace after ','
cowrie/test/test_base_commands.py:198:42: E231 missing whitespace after ','
1     E211 whitespace before '('
26    E231 missing whitespace after ','
27

* flake8 E2 cowrie/test/fake_transport.py

flake8 --count --select=E1,E2 --statistics cowrie/test/fake_transport.py
cowrie/test/fake_transport.py:8:42: E231 missing whitespace after ','
1     E231 missing whitespace after ','
1

* flake8 E2 cowrie/proxy/endpoints.py

flake8 --count --select=E1,E2 --statistics cowrie/proxy/endpoints.py
cowrie/proxy/endpoints.py:214:29: E226 missing whitespace around arithmetic operator
cowrie/proxy/endpoints.py:233:42: E226 missing whitespace around arithmetic operator
cowrie/proxy/endpoints.py:323:22: E231 missing whitespace after ','
cowrie/proxy/endpoints.py:323:25: E231 missing whitespace after ','
cowrie/proxy/endpoints.py:323:27: E231 missing whitespace after ','
cowrie/proxy/endpoints.py:323:30: E261 at least two spaces before inline comment
cowrie/proxy/endpoints.py:346:55: E226 missing whitespace around arithmetic operator
cowrie/proxy/endpoints.py:380:48: E226 missing whitespace around arithmetic operator
cowrie/proxy/endpoints.py:824:24: E222 multiple spaces after operator
cowrie/proxy/endpoints.py:992:24: E222 multiple spaces after operator
2     E222 multiple spaces after operator
4     E226 missing whitespace around arithmetic operator
3     E231 missing whitespace after ','
1     E261 at least two spaces before inline comment
10

* flake8 E2 cowrie/proxy/avatar.py

flake8 --count --select=E1,E2 --statistics cowrie/proxy/avatar.py
cowrie/proxy/avatar.py:14:1: E265 block comment should start with '# '
cowrie/proxy/avatar.py:38:9: E265 block comment should start with '# '
cowrie/proxy/avatar.py:41:9: E265 block comment should start with '# '
cowrie/proxy/avatar.py:59:1: E265 block comment should start with '# '
4     E265 block comment should start with '# '
4

* Add TODO for checking SFTP support

I removed code which was never used in this version of cowrie. But for
me it looks like there is no SFTP support anymore? Look the previous
commit message for more details.

* flake8 E2 cowrie/proxy/session.py

flake8 --count --select=E1,E2 --statistics cowrie/proxy/session.py
cowrie/proxy/session.py:15:1: E265 block comment should start with '# '
cowrie/proxy/session.py:60:21: E261 at least two spaces before inline comment
cowrie/proxy/session.py:61:18: E261 at least two spaces before inline comment
cowrie/proxy/session.py:62:14: E261 at least two spaces before inline comment
cowrie/proxy/session.py:71:13: E265 block comment should start with '# '
cowrie/proxy/session.py:83:30: E226 missing whitespace around arithmetic operator
cowrie/proxy/session.py:83:42: E226 missing whitespace around arithmetic operator
cowrie/proxy/session.py:83:59: E226 missing whitespace around arithmetic operator
cowrie/proxy/session.py:91:37: E226 missing whitespace around arithmetic operator
cowrie/proxy/session.py:146:9: E265 block comment should start with '# '
cowrie/proxy/session.py:168:32: E226 missing whitespace around arithmetic operator
cowrie/proxy/session.py:169:26: E226 missing whitespace around arithmetic operator
cowrie/proxy/session.py:170:26: E226 missing whitespace around arithmetic operator
cowrie/proxy/session.py:171:26: E226 missing whitespace around arithmetic operator
cowrie/proxy/session.py:185:28: E226 missing whitespace around arithmetic operator
cowrie/proxy/session.py:189:23: E226 missing whitespace around arithmetic operator
cowrie/proxy/session.py:250:9: E265 block comment should start with '# '
cowrie/proxy/session.py:322:13: E265 block comment should start with '# '
10    E226 missing whitespace around arithmetic operator
3     E261 at least two spaces before inline comment
5     E265 block comment should start with '# '
18

* flake8 E2 cowire/core/dblog.py

flake8 --count --select=E1,E2 --statistics cowrie/core/dblog.py
cowrie/core/dblog.py:27:9: E265 block comment should start with '# '
1     E265 block comment should start with '# '
1

* flake8 E2 cowrie/core/output.py

flake8 --count --select=E1,E2 --statistics cowrie/core/output.py
cowrie/core/output.py:172:9: E265 block comment should start with '# '
cowrie/core/output.py:174:13: E265 block comment should start with '# '
cowrie/core/output.py:175:13: E265 block comment should start with '# '
cowrie/core/output.py:176:13: E265 block comment should start with '# '
cowrie/core/output.py:177:13: E265 block comment should start with '# '
cowrie/core/output.py:188:32: E226 missing whitespace around arithmetic operator
cowrie/core/output.py:192:36: E226 missing whitespace around arithmetic operator
2     E226 missing whitespace around arithmetic operator
5     E265 block comment should start with '# '
7

* flake8 E2 cowrie/core/realm.py

flake8 --count --select=E1,E2 --statistics cowrie/core/realm.py
cowrie/core/realm.py:72:9: E265 block comment should start with '# '
1     E265 block comment should start with '# '
1

* flake8 E2 cowrie/core/utils.py

flake8 --count --select=E1,E2 --statistics cowrie/core/utils.py
cowrie/core/utils.py:35:55: E226 missing whitespace around arithmetic operator
cowrie/core/utils.py:38:56: E226 missing whitespace around arithmetic operator
cowrie/core/utils.py:57:22: E226 missing whitespace around arithmetic operator
cowrie/core/utils.py:58:45: E226 missing whitespace around arithmetic operator
cowrie/core/utils.py:59:35: E226 missing whitespace around arithmetic operator
5     E226 missing whitespace around arithmetic operator
5

* Enable flake8 E1 and E2 checks in travis

Prevent bad code style of fixed flake8 errors again in the code.

* Fixing missspelled variable
2018-07-05 22:46:00 +04:00
a0ed8135ea changelog for txtcmds 2018-06-28 15:47:51 +04:00
9b10526eb7 move txtcmds to share/cowrie/txtcmds 2018-06-28 15:47:09 +04:00
94349fd7a9 ignore auth_random.json 2018-06-28 15:42:52 +04:00
a0729e422c store auth_random state in var/lib/cowrie/auth_random.json 2018-06-28 15:35:52 +04:00
75e7e33e0a add var/lib/cowrie for state information 2018-06-28 15:28:08 +04:00
3a0911e6d9 move pickle file 2018-06-28 03:31:05 +04:00
176cdf3b78 extended interpolation 2018-06-28 03:21:55 +04:00
7a1b77892c add etcpath 2018-06-28 02:55:30 +04:00
9644dc3d99 move arch files to share dir 2018-06-28 02:47:11 +04:00
b1083c115b revert INSTALL 2018-06-28 02:30:38 +04:00
bd4a631863 updates 2018-06-28 02:09:35 +04:00
84ecadccff updates 2018-06-28 01:57:50 +04:00
5d1509e871 more updates 2018-06-28 01:41:34 +04:00
64070c416c moar 2018-06-28 01:09:55 +04:00
e6cdb30425 more updates 2018-06-28 01:03:18 +04:00
ae7a3c08ed updates 2018-06-28 00:53:15 +04:00
455c2351a0 changest 2018-06-28 00:35:16 +04:00
4985b9af78 small fixes 2018-06-28 00:23:11 +04:00
c613bcb5f8 Merge branch 'master' of http://www.github.com/micheloosterhof/cowrie 2018-06-28 00:14:24 +04:00
aa86048bf2 Improve systemd support, fixing bad practises (#792)
This is now a huge patch but several things has get together or are part
of each other so let me try to explain why I made several changes.

INSTALL.md
==========

systemd
-------

This should work on systems with with systemd like Ubuntu 18.04 or
Debian 9. I did not tested it against anything else.

1. I removed authbind from the dependencies because we have now systemd
for running on ports < 1024.
2. We are running a daemon. That user is not supposed to have a homedir
or even worse to have a shell. For security reasons no /bin/bash.
3. cowrie can and should be installed into /opt. The place on linux
where you put software in when you have no clue where to put it.
4. The virtualenv should not be inside the cowrie directory. That's a
different part of running our service but is not shipped with the code.
So the new path should be /opt/cowrie-env.
5. We want to write as less as possible into /opt keep more the linux
way of writing files of a daemon. TTY logs and downloads should be
stored into /var/lib/cowrie/.
(TODO: the date directory contains still files which should be written
into /var/lib/cowrie instead of data/.)
6. The sweet stuff. Installing configurations for systemd, rsyslog and
logrotate (more details for this later in this commit message)
7. Installing a pre-configured cowrie config for systemd and better
linux integration (TODO: That file should move to /etc/cowrie/cowrie.cfg)
8. How to start cowrie with systemd now
9. How to catch live traffic. I removed the authbind section from it.
Not needed anymore. I also recommend to reconfigure your ssh and cowrie
service to listen on different ports. This is more easier and quicker
then involing iptables/nftables.

no systemd
----------

1. I removed here also the authbind package because it is mentioned
later in the install instructions and I think it should be installed
when the user is really using that feature.
2. The user here will now also be a system user but with a /bin/bash as
shell. Unfortunally the start/stop script needs a bash to work.
That's a security drawback which systemd doesn't have.
3. Changing the path to /opt
4. I didn't wanted to touch the bin/cowrie script so the virtualenv is
still installed below the cowrie directory. I don't really like this
because like above explained we do not ship the code so it should be a
different directory.
5 and 6 not touched
7. If we follow the instructions we are having now the code in
/opt/cowrie where only root can writes into. So some parts needs to have
other permissions to allow reading and writing by cowrie.
8. Start the cowrie daemon with the right user from the root shell.
9. The section port redirecting is IMHO not optional because otherwise
we would not get much traffic. I have seen people knocking on port 2222
but cowrie should get the traffic from the ssh port.
I also added a note for non experienced users when dealing with the
pre-routing iptables rules.

Configfiles
===========

systemd socket
--------------
Systemd handles now the sockets for port binding. No authbind or other
dirty hacks needed anymore.

systemd service
---------------
Systemd also handles now the service. It takes care that every
dependency is up before cowrie is started. No supervisord needed anymore

rsyslog
-------
Logfiles are now written into /var/log/cowrie. Also the json file can be
logged here into. Permissions are set that cowrie can also writes into
the directory.

logrotate
---------
Every week we rotate the logfiles in /var/log/cowrie and store 4
compressed log files of it before deleting them.
2018-06-28 00:14:12 +04:00
96c4b3c468 Fixing flake8 E1 errors (#793)
* flake8 E1 cowrie/core/checkers.py

Removing also unused code.

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*checkers.py"
./cowrie/core/checkers.py:72:9: E128 continuation line under-indented for visual indent
./cowrie/core/checkers.py:121:21: E128 continuation line under-indented for visual indent
./cowrie/core/checkers.py:129:21: E116 unexpected indentation (comment)
./cowrie/core/checkers.py:130:21: E116 unexpected indentation (comment)
./cowrie/core/checkers.py:136:21: E116 unexpected indentation (comment)
./cowrie/core/checkers.py:137:21: E116 unexpected indentation (comment)
4     E116 unexpected indentation (comment)
2     E128 continuation line under-indented for visual indent
6

* flake8 E1 cowrie/core/cef.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*cef.py"
./cowrie/core/cef.py:104:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:105:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:106:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:107:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:108:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:109:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:110:7: E127 continuation line over-indented for visual indent
7     E127 continuation line over-indented for visual indent
7

* flake8 E1 cowrie/proxy/session.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*proxy/session.py"
./cowrie/proxy/session.py:182:13: E128 continuation line under-indented for visual indent
./cowrie/proxy/session.py:213:13: E128 continuation line under-indented for visual indent
./cowrie/proxy/session.py:251:13: E128 continuation line under-indented for visual indent
./cowrie/proxy/session.py:261:13: E128 continuation line under-indented for visual indent
./cowrie/proxy/session.py:262:13: E128 continuation line under-indented for visual indent
5     E128 continuation line under-indented for visual indent
5

* flake8 E1 twisted/plugins/cowrie_plugin.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*cowrie_plugin.py"
./twisted/plugins/cowrie_plugin.py:69:9: E123 closing bracket does not match indentation of opening bracket's line
./twisted/plugins/cowrie_plugin.py:73:9: E123 closing bracket does not match indentation of opening bracket's line
./twisted/plugins/cowrie_plugin.py:189:22: E127 continuation line over-indented for visual indent
2     E123 closing bracket does not match indentation of opening bracket's line
1     E127 continuation line over-indented for visual indent
3

* flake8 E1 cowrie/insults/insults.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*insults.py"
./cowrie/insults/insults.py:47:17: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:74:17: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:79:17: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:80:17: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:84:13: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:105:17: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:117:11: E127 continuation line over-indented for visual indent
./cowrie/insults/insults.py:128:17: E128 continuation line under-indented for visual indent
1     E127 continuation line over-indented for visual indent
7     E128 continuation line under-indented for visual indent
8

* flake8 E1 cowrie/telnet/session.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*telnet/session.py"
./cowrie/telnet/session.py:18:34: E126 continuation line over-indented for hanging indent
1     E126 continuation line over-indented for hanging indent
1

* flake8 E1 cowrie/telnet/transport.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*telnet/transport.py"
./cowrie/telnet/transport.py:17:34: E126 continuation line over-indented for hanging indent
./cowrie/telnet/transport.py:59:42: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:233:12: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:234:12: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:235:12: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:236:12: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:260:13: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:261:13: E128 continuation line under-indented for visual indent
1     E126 continuation line over-indented for hanging indent
7     E128 continuation line under-indented for visual indent
8

* flake8 E1 cowrie/dblog/xmpp.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*xmpp.py"
./cowrie/dblog/xmpp.py:79:13: E128 continuation line under-indented for visual indent
./cowrie/dblog/xmpp.py:105:17: E128 continuation line under-indented for visual indent
2     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/commands/ping.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*ping.py"
./cowrie/commands/ping.py:63:21: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/commands/ping.py:78:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ping.py:82:13: E128 continuation line under-indented for visual indent
./cowrie/commands/ping.py:109:13: E128 continuation line under-indented for visual indent
1     E123 closing bracket does not match indentation of opening bracket's line
3     E128 continuation line under-indented for visual indent
4

* flake8 E1 cowrie/commands/uptime.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*uptime.py"
./cowrie/commands/uptime.py:21:13: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/commands/base.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*base.py"
./cowrie/commands/base.py:97:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py💯13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:101:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:102:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:114:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:115:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:116:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:117:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:297:13: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/commands/base.py:310:21: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:327:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:402:17: E123 closing bracket does not match indentation of opening bracket's line
2     E123 closing bracket does not match indentation of opening bracket's line
10    E128 continuation line under-indented for visual indent
12

* flake8 E1 cowrie/commands/scp.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*scp.py"
./cowrie/commands/scp.py:65:12: E111 indentation is not a multiple of four
./cowrie/commands/scp.py:67:12: E111 indentation is not a multiple of four
2     E111 indentation is not a multiple of four
2

* flake8 E1 cowrie/commands/ifconfig.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*ifconfig.py"
./cowrie/commands/ifconfig.py:32:9: E122 continuation line missing indentation or outdented
./cowrie/commands/ifconfig.py:33:9: E128 continuation line under-indented for visual indent
1     E122 continuation line missing indentation or outdented
1     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/commands/ssh.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/ssh.py"

./cowrie/commands/ssh.py:41:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ssh.py:58:21: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/commands/ssh.py:78:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ssh.py:84:13: E128 continuation line under-indented for visual indent
./cowrie/commands/ssh.py:123:13: E128 continuation line under-indented for visual indent
1     E123 closing bracket does not match indentation of opening bracket's line
4     E128 continuation line under-indented for visual indent
5

* flake8 E1 cowrie/commands/iptables.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*iptables.py"
./cowrie/commands/iptables.py:388:13: E128 continuation line under-indented for visual indent
./cowrie/commands/iptables.py:396:13: E128 continuation line under-indented for visual indent
./cowrie/commands/iptables.py:404:13: E128 continuation line under-indented for visual indent
./cowrie/commands/iptables.py:412:13: E128 continuation line under-indented for visual indent
4     E128 continuation line under-indented for visual indent
4

* flake8 E1 cowrie/commands/adduser.py

flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*adduser.py"
./cowrie/commands/adduser.py:61:13: E123 closing bracket does not match indentation of opening bracket's line
1     E123 closing bracket does not match indentation of opening bracket's line
1

* flake8 E1 cowrie/commands/apt.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*apt.py"
./cowrie/commands/apt.py:123:21: E131 continuation line unaligned for hanging indent
./cowrie/commands/apt.py:124:21: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:125:21: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:127:17: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/commands/apt.py:136:13: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:139:13: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:143:17: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:154:17: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:160:17: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:162:17: E128 continuation line under-indented for visual indent
1     E123 closing bracket does not match indentation of opening bracket's line
8     E128 continuation line under-indented for visual indent
1     E131 continuation line unaligned for hanging indent
10

* flake8 E1 cowrie/commands/fs.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/fs.py"
./cowrie/commands/fs.py:340:28: E128 continuation line under-indented for visual indent
./cowrie/commands/fs.py:396:25: E127 continuation line over-indented for visual indent
./cowrie/commands/fs.py:408:28: E128 continuation line under-indented for visual indent
1     E127 continuation line over-indented for visual indent
2     E128 continuation line under-indented for visual indent
3

* flake8 E1 cowrie/commands/last.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/last.py"
./cowrie/commands/last.py:30:13: E128 continuation line under-indented for visual indent
./cowrie/commands/last.py:35:14: E128 continuation line under-indented for visual indent
2     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/commands/netstat.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/netstat.py"
./cowrie/commands/netstat.py:71:13: E128 continuation line under-indented for visual indent
./cowrie/commands/netstat.py:74:13: E128 continuation line under-indented for visual indent
./cowrie/commands/netstat.py:98:17: E128 continuation line under-indented for visual indent
./cowrie/commands/netstat.py:99:17: E128 continuation line under-indented for visual indent
4     E128 continuation line under-indented for visual indent
4

* flake8 E1 cowrie/commands/ls.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/ls.py"
./cowrie/commands/ls.py:182:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ls.py:183:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ls.py:184:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ls.py:185:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ls.py:186:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ls.py:187:17: E128 continuation line under-indented for visual indent
6     E128 continuation line under-indented for visual indent
6

* flake8 E1 cowrie/commands/__init__.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/__init__.py"
./cowrie/commands/__init__.py:41:5: E123 closing bracket does not match indentation of opening bracket's line
1     E123 closing bracket does not match indentation of opening bracket's line
1

* flake8 E1 cowrie/commands/cat.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*cat.py"
./cowrie/commands/cat.py:105:1: E122 continuation line missing indentation or outdented
1     E122 continuation line missing indentation or outdented
1

* flake8 E1 cowrie/commands/tar.py

* flake8 E1 cowrie/commands/sudo.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*sudo.py"
./cowrie/commands/sudo.py:82:1: E122 continuation line missing indentation or outdented
./cowrie/commands/sudo.py:122:17: E128 continuation line under-indented for visual indent
1     E122 continuation line missing indentation or outdented
1     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/commands/curl.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*curl.py"
./cowrie/commands/curl.py:38:17: E128 continuation line under-indented for visual indent
./cowrie/commands/curl.py:83:21: E128 continuation line under-indented for visual indent
./cowrie/commands/curl.py:377:13: E128 continuation line under-indented for visual indent
./cowrie/commands/curl.py:412:21: E128 continuation line under-indented for visual indent
./cowrie/commands/curl.py:459:17: E128 continuation line under-indented for visual indent
5     E128 continuation line under-indented for visual indent
5

* flake8 E1 cowrie/commands/service.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*service.py"
./cowrie/commands/service.py:28:10: E121 continuation line under-indented for hanging indent
1     E121 continuation line under-indented for hanging indent
1

* flake8 E1 cowrie/ssh/connection.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*connection.py"
./cowrie/ssh/connection.py:60:17: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/ssh/factory.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*factory.py"
./cowrie/ssh/factory.py:34:9: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/ssh/factory.py:62:11: E121 continuation line under-indented for hanging indent
./cowrie/ssh/factory.py:65:11: E121 continuation line under-indented for hanging indent
./cowrie/ssh/factory.py:119:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/factory.py:120:13: E128 continuation line under-indented for visual indent
2     E121 continuation line under-indented for hanging indent
1     E123 closing bracket does not match indentation of opening bracket's line
2     E128 continuation line under-indented for visual indent
5

* flake8 E1 cowrie/ssh/channel.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*channel.py"
./cowrie/ssh/channel.py:56:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:69:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:71:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:72:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:81:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:82:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:83:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:84:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:98:11: E127 continuation line over-indented for visual indent
./cowrie/ssh/channel.py:105:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:119:17: E128 continuation line under-indented for visual indent
1     E127 continuation line over-indented for visual indent
10    E128 continuation line under-indented for visual indent
11

* flake8 E1 cowrie/ssh/userauth.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*userauth.py"
./cowrie/ssh/userauth.py:102:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/userauth.py:115:21: E126 continuation line over-indented for hanging indent
./cowrie/ssh/userauth.py:120:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/userauth.py:122:13: E128 continuation line under-indented for visual indent
1     E126 continuation line over-indented for hanging indent
3     E128 continuation line under-indented for visual indent
4

* flake8 E1 cowrie/ssh/forwarding.py

flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*forwarding.py"
./cowrie/ssh/forwarding.py:23:9: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:24:9: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:25:9: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:47:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:52:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:74:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:79:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:82:12: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:114:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:115:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:149:13: E128 continuation line under-indented for visual indent
11    E128 continuation line under-indented for visual indent
11

* flake8 E1 cowrie/ssh/transport.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*transport.py"
./cowrie/ssh/transport.py:56:12: E128 continuation line under-indented for visual indent
./cowrie/ssh/transport.py:57:12: E128 continuation line under-indented for visual indent
./cowrie/ssh/transport.py:58:12: E128 continuation line under-indented for visual indent
./cowrie/ssh/transport.py:59:12: E128 continuation line under-indented for visual indent
./cowrie/ssh/transport.py:213:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/transport.py:214:13: E128 continuation line under-indented for visual indent
6     E128 continuation line under-indented for visual indent
6

* flake8 E1 cowrie/output/mysql.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*mysql.py"
./cowrie/output/mysql.py:73:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:131:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:132:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:133:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:134:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:138:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:139:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:140:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:141:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:145:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:146:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:150:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:151:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:152:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:156:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:157:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:158:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:162:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:163:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:164:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:165:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:169:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:170:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:171:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:172:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:176:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:177:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:178:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:179:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:183:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:184:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:185:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:186:17: E128 continuation line under-indented for visual indent
33    E128 continuation line under-indented for visual indent
33

* flake8 E1 cowrie/output/hpfeeds.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*hpfeeds.py"
./cowrie/output/hpfeeds.py:199:21: E128 continuation line under-indented for visual indent
./cowrie/output/hpfeeds.py:203:21: E128 continuation line under-indented for visual indent
./cowrie/output/hpfeeds.py:212:34: E128 continuation line under-indented for visual indent
./cowrie/output/hpfeeds.py:215:34: E126 continuation line over-indented for hanging indent
./cowrie/output/hpfeeds.py:298:17: E128 continuation line under-indented for visual indent
./cowrie/output/hpfeeds.py:299:17: E128 continuation line under-indented for visual indent
1     E126 continuation line over-indented for hanging indent
5     E128 continuation line under-indented for visual indent
6

* flake8 E1 cowrie/output/hpfeeds3.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*hpfeeds3.py"
./cowrie/output/hpfeeds3.py:68:17: E128 continuation line under-indented for visual indent
./cowrie/output/hpfeeds3.py:69:17: E128 continuation line under-indented for visual indent
2     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/output/s3.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*s3.py"
./cowrie/output/s3.py:31:11: E111 indentation is not a multiple of four
1     E111 indentation is not a multiple of four
1

* flake8 E1 cowrie/output/malshare.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*malshare.py"
./cowrie/output/malshare.py:97:21: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/output/sqlite.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*sqlite.py"
./cowrie/output/sqlite.py:35:21: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:89:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:90:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:91:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:92:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:96:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:97:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:98:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:99:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:103:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:104:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:105:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:106:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:110:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:111:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:112:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:113:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:117:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:118:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:122:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:123:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:124:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:125:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:129:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:130:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:131:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:132:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:136:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:137:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:138:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:139:17: E128 continuation line under-indented for visual indent
31    E128 continuation line under-indented for visual indent
31

* flake8 E1 cowrie/output/influx.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*influx.py"
./cowrie/output/influx.py:145:17: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/output/influx.py:150:17: E123 closing bracket does not match indentation of opening bracket's line
2     E123 closing bracket does not match indentation of opening bracket's line
2

* flake8 E1 cowrie/output/cuckoo.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*cuckoo.py"
./cowrie/output/cuckoo.py:106:17: E128 continuation line under-indented for visual indent
./cowrie/output/cuckoo.py:107:17: E128 continuation line under-indented for visual indent
./cowrie/output/cuckoo.py:108:17: E128 continuation line under-indented for visual indent
./cowrie/output/cuckoo.py:124:29: E126 continuation line over-indented for hanging indent
./cowrie/output/cuckoo.py:126:25: E126 continuation line over-indented for hanging indent
./cowrie/output/cuckoo.py:127:25: E126 continuation line over-indented for hanging indent
./cowrie/output/cuckoo.py:144:29: E126 continuation line over-indented for hanging indent
./cowrie/output/cuckoo.py:146:25: E126 continuation line over-indented for hanging indent
./cowrie/output/cuckoo.py:147:25: E126 continuation line over-indented for hanging indent
6     E126 continuation line over-indented for hanging indent
3     E128 continuation line under-indented for visual indent
9

* flake8 E1 cowrie/output/dshield.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*dshield.py"
./cowrie/output/dshield.py:84:17: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:89:13: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:92:19: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:99:33: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py💯33: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:101:33: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:102:33: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:103:33: E128 continuation line under-indented for visual indent
8     E128 continuation line under-indented for visual indent
8

* flake8 E1 cowrie/shell/honeypot.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/honeypot.py"
./cowrie/shell/honeypot.py:489:17: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/shell/fs.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/fs.py"
./cowrie/shell/fs.py:177:29: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:236:33: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:240:33: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:286:13: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:306:13: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:379:21: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:380:21: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:562:17: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:570:13: E128 continuation line under-indented for visual indent
9     E128 continuation line under-indented for visual indent
9

* flake8 E1 cowrie/shell/filetransfer.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/filetransfer.py"
./cowrie/shell/filetransfer.py:192:11: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/shell/pwd.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/pwd.py"
./cowrie/shell/pwd.py:49:13: E128 continuation line under-indented for visual indent
./cowrie/shell/pwd.py:132:13: E128 continuation line under-indented for visual indent
2     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/shell/session.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/session.py"
./cowrie/shell/session.py:68:13: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/shell/protocol.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/protocol.py"
./cowrie/shell/protocol.py:57:21: E128 continuation line under-indented for visual indent
./cowrie/shell/protocol.py:179:21: E128 continuation line under-indented for visual indent
./cowrie/shell/protocol.py:185:13: E128 continuation line under-indented for visual indent
./cowrie/shell/protocol.py:321:13: E123 closing bracket does not match indentation of opening bracket's line
1     E123 closing bracket does not match indentation of opening bracket's line
3     E128 continuation line under-indented for visual indent
4
2018-06-28 00:06:00 +04:00
330e284fb1 2 separate imports 2018-06-27 12:36:04 +04:00
4f62c56341 py3 fixes for proxy 2018-06-27 12:35:37 +04:00
786d09e29d Added Elasticsearch Pipeline (#788) 2018-06-24 10:46:29 +04:00
b10921fa45 syntax error 2018-06-23 17:14:59 +00:00
2611a98355 update 2018-06-23 17:13:55 +00:00
55a083b018 Log version earlier. Log KEX attributes in fingerprint emssage 2018-06-23 17:12:55 +00:00
558bd2a6e0 document pre-post login banner 2018-06-23 17:06:51 +00:00
080985c4fc copy openssh behavior on 1.x verison string 2018-06-23 16:51:31 +00:00
291ed78d85 py3 mention 2018-06-22 11:50:45 +00:00
047aa63724 dont' use 'basestring'. 2018-06-22 09:33:44 +00:00
de0b1f93ba optionally accept bytes to write() 2018-06-22 09:33:23 +00:00