Commit Graph

2273 Commits

Author SHA1 Message Date
bd4a631863 updates 2018-06-28 02:09:35 +04:00
84ecadccff updates 2018-06-28 01:57:50 +04:00
5d1509e871 more updates 2018-06-28 01:41:34 +04:00
64070c416c moar 2018-06-28 01:09:55 +04:00
e6cdb30425 more updates 2018-06-28 01:03:18 +04:00
ae7a3c08ed updates 2018-06-28 00:53:15 +04:00
455c2351a0 changest 2018-06-28 00:35:16 +04:00
4985b9af78 small fixes 2018-06-28 00:23:11 +04:00
c613bcb5f8 Merge branch 'master' of http://www.github.com/micheloosterhof/cowrie 2018-06-28 00:14:24 +04:00
aa86048bf2 Improve systemd support, fixing bad practises (#792)
This is now a huge patch but several things has get together or are part
of each other so let me try to explain why I made several changes.

INSTALL.md
==========

systemd
-------

This should work on systems with with systemd like Ubuntu 18.04 or
Debian 9. I did not tested it against anything else.

1. I removed authbind from the dependencies because we have now systemd
for running on ports < 1024.
2. We are running a daemon. That user is not supposed to have a homedir
or even worse to have a shell. For security reasons no /bin/bash.
3. cowrie can and should be installed into /opt. The place on linux
where you put software in when you have no clue where to put it.
4. The virtualenv should not be inside the cowrie directory. That's a
different part of running our service but is not shipped with the code.
So the new path should be /opt/cowrie-env.
5. We want to write as less as possible into /opt keep more the linux
way of writing files of a daemon. TTY logs and downloads should be
stored into /var/lib/cowrie/.
(TODO: the date directory contains still files which should be written
into /var/lib/cowrie instead of data/.)
6. The sweet stuff. Installing configurations for systemd, rsyslog and
logrotate (more details for this later in this commit message)
7. Installing a pre-configured cowrie config for systemd and better
linux integration (TODO: That file should move to /etc/cowrie/cowrie.cfg)
8. How to start cowrie with systemd now
9. How to catch live traffic. I removed the authbind section from it.
Not needed anymore. I also recommend to reconfigure your ssh and cowrie
service to listen on different ports. This is more easier and quicker
then involing iptables/nftables.

no systemd
----------

1. I removed here also the authbind package because it is mentioned
later in the install instructions and I think it should be installed
when the user is really using that feature.
2. The user here will now also be a system user but with a /bin/bash as
shell. Unfortunally the start/stop script needs a bash to work.
That's a security drawback which systemd doesn't have.
3. Changing the path to /opt
4. I didn't wanted to touch the bin/cowrie script so the virtualenv is
still installed below the cowrie directory. I don't really like this
because like above explained we do not ship the code so it should be a
different directory.
5 and 6 not touched
7. If we follow the instructions we are having now the code in
/opt/cowrie where only root can writes into. So some parts needs to have
other permissions to allow reading and writing by cowrie.
8. Start the cowrie daemon with the right user from the root shell.
9. The section port redirecting is IMHO not optional because otherwise
we would not get much traffic. I have seen people knocking on port 2222
but cowrie should get the traffic from the ssh port.
I also added a note for non experienced users when dealing with the
pre-routing iptables rules.

Configfiles
===========

systemd socket
--------------
Systemd handles now the sockets for port binding. No authbind or other
dirty hacks needed anymore.

systemd service
---------------
Systemd also handles now the service. It takes care that every
dependency is up before cowrie is started. No supervisord needed anymore

rsyslog
-------
Logfiles are now written into /var/log/cowrie. Also the json file can be
logged here into. Permissions are set that cowrie can also writes into
the directory.

logrotate
---------
Every week we rotate the logfiles in /var/log/cowrie and store 4
compressed log files of it before deleting them.
2018-06-28 00:14:12 +04:00
96c4b3c468 Fixing flake8 E1 errors (#793)
* flake8 E1 cowrie/core/checkers.py

Removing also unused code.

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*checkers.py"
./cowrie/core/checkers.py:72:9: E128 continuation line under-indented for visual indent
./cowrie/core/checkers.py:121:21: E128 continuation line under-indented for visual indent
./cowrie/core/checkers.py:129:21: E116 unexpected indentation (comment)
./cowrie/core/checkers.py:130:21: E116 unexpected indentation (comment)
./cowrie/core/checkers.py:136:21: E116 unexpected indentation (comment)
./cowrie/core/checkers.py:137:21: E116 unexpected indentation (comment)
4     E116 unexpected indentation (comment)
2     E128 continuation line under-indented for visual indent
6

* flake8 E1 cowrie/core/cef.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*cef.py"
./cowrie/core/cef.py:104:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:105:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:106:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:107:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:108:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:109:7: E127 continuation line over-indented for visual indent
./cowrie/core/cef.py:110:7: E127 continuation line over-indented for visual indent
7     E127 continuation line over-indented for visual indent
7

* flake8 E1 cowrie/proxy/session.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*proxy/session.py"
./cowrie/proxy/session.py:182:13: E128 continuation line under-indented for visual indent
./cowrie/proxy/session.py:213:13: E128 continuation line under-indented for visual indent
./cowrie/proxy/session.py:251:13: E128 continuation line under-indented for visual indent
./cowrie/proxy/session.py:261:13: E128 continuation line under-indented for visual indent
./cowrie/proxy/session.py:262:13: E128 continuation line under-indented for visual indent
5     E128 continuation line under-indented for visual indent
5

* flake8 E1 twisted/plugins/cowrie_plugin.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*cowrie_plugin.py"
./twisted/plugins/cowrie_plugin.py:69:9: E123 closing bracket does not match indentation of opening bracket's line
./twisted/plugins/cowrie_plugin.py:73:9: E123 closing bracket does not match indentation of opening bracket's line
./twisted/plugins/cowrie_plugin.py:189:22: E127 continuation line over-indented for visual indent
2     E123 closing bracket does not match indentation of opening bracket's line
1     E127 continuation line over-indented for visual indent
3

* flake8 E1 cowrie/insults/insults.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*insults.py"
./cowrie/insults/insults.py:47:17: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:74:17: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:79:17: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:80:17: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:84:13: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:105:17: E128 continuation line under-indented for visual indent
./cowrie/insults/insults.py:117:11: E127 continuation line over-indented for visual indent
./cowrie/insults/insults.py:128:17: E128 continuation line under-indented for visual indent
1     E127 continuation line over-indented for visual indent
7     E128 continuation line under-indented for visual indent
8

* flake8 E1 cowrie/telnet/session.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*telnet/session.py"
./cowrie/telnet/session.py:18:34: E126 continuation line over-indented for hanging indent
1     E126 continuation line over-indented for hanging indent
1

* flake8 E1 cowrie/telnet/transport.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*telnet/transport.py"
./cowrie/telnet/transport.py:17:34: E126 continuation line over-indented for hanging indent
./cowrie/telnet/transport.py:59:42: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:233:12: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:234:12: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:235:12: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:236:12: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:260:13: E128 continuation line under-indented for visual indent
./cowrie/telnet/transport.py:261:13: E128 continuation line under-indented for visual indent
1     E126 continuation line over-indented for hanging indent
7     E128 continuation line under-indented for visual indent
8

* flake8 E1 cowrie/dblog/xmpp.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*xmpp.py"
./cowrie/dblog/xmpp.py:79:13: E128 continuation line under-indented for visual indent
./cowrie/dblog/xmpp.py:105:17: E128 continuation line under-indented for visual indent
2     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/commands/ping.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*ping.py"
./cowrie/commands/ping.py:63:21: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/commands/ping.py:78:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ping.py:82:13: E128 continuation line under-indented for visual indent
./cowrie/commands/ping.py:109:13: E128 continuation line under-indented for visual indent
1     E123 closing bracket does not match indentation of opening bracket's line
3     E128 continuation line under-indented for visual indent
4

* flake8 E1 cowrie/commands/uptime.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*uptime.py"
./cowrie/commands/uptime.py:21:13: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/commands/base.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*base.py"
./cowrie/commands/base.py:97:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py💯13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:101:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:102:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:114:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:115:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:116:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:117:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:297:13: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/commands/base.py:310:21: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:327:13: E128 continuation line under-indented for visual indent
./cowrie/commands/base.py:402:17: E123 closing bracket does not match indentation of opening bracket's line
2     E123 closing bracket does not match indentation of opening bracket's line
10    E128 continuation line under-indented for visual indent
12

* flake8 E1 cowrie/commands/scp.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*scp.py"
./cowrie/commands/scp.py:65:12: E111 indentation is not a multiple of four
./cowrie/commands/scp.py:67:12: E111 indentation is not a multiple of four
2     E111 indentation is not a multiple of four
2

* flake8 E1 cowrie/commands/ifconfig.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*ifconfig.py"
./cowrie/commands/ifconfig.py:32:9: E122 continuation line missing indentation or outdented
./cowrie/commands/ifconfig.py:33:9: E128 continuation line under-indented for visual indent
1     E122 continuation line missing indentation or outdented
1     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/commands/ssh.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/ssh.py"

./cowrie/commands/ssh.py:41:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ssh.py:58:21: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/commands/ssh.py:78:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ssh.py:84:13: E128 continuation line under-indented for visual indent
./cowrie/commands/ssh.py:123:13: E128 continuation line under-indented for visual indent
1     E123 closing bracket does not match indentation of opening bracket's line
4     E128 continuation line under-indented for visual indent
5

* flake8 E1 cowrie/commands/iptables.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*iptables.py"
./cowrie/commands/iptables.py:388:13: E128 continuation line under-indented for visual indent
./cowrie/commands/iptables.py:396:13: E128 continuation line under-indented for visual indent
./cowrie/commands/iptables.py:404:13: E128 continuation line under-indented for visual indent
./cowrie/commands/iptables.py:412:13: E128 continuation line under-indented for visual indent
4     E128 continuation line under-indented for visual indent
4

* flake8 E1 cowrie/commands/adduser.py

flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*adduser.py"
./cowrie/commands/adduser.py:61:13: E123 closing bracket does not match indentation of opening bracket's line
1     E123 closing bracket does not match indentation of opening bracket's line
1

* flake8 E1 cowrie/commands/apt.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*apt.py"
./cowrie/commands/apt.py:123:21: E131 continuation line unaligned for hanging indent
./cowrie/commands/apt.py:124:21: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:125:21: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:127:17: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/commands/apt.py:136:13: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:139:13: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:143:17: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:154:17: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:160:17: E128 continuation line under-indented for visual indent
./cowrie/commands/apt.py:162:17: E128 continuation line under-indented for visual indent
1     E123 closing bracket does not match indentation of opening bracket's line
8     E128 continuation line under-indented for visual indent
1     E131 continuation line unaligned for hanging indent
10

* flake8 E1 cowrie/commands/fs.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/fs.py"
./cowrie/commands/fs.py:340:28: E128 continuation line under-indented for visual indent
./cowrie/commands/fs.py:396:25: E127 continuation line over-indented for visual indent
./cowrie/commands/fs.py:408:28: E128 continuation line under-indented for visual indent
1     E127 continuation line over-indented for visual indent
2     E128 continuation line under-indented for visual indent
3

* flake8 E1 cowrie/commands/last.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/last.py"
./cowrie/commands/last.py:30:13: E128 continuation line under-indented for visual indent
./cowrie/commands/last.py:35:14: E128 continuation line under-indented for visual indent
2     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/commands/netstat.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/netstat.py"
./cowrie/commands/netstat.py:71:13: E128 continuation line under-indented for visual indent
./cowrie/commands/netstat.py:74:13: E128 continuation line under-indented for visual indent
./cowrie/commands/netstat.py:98:17: E128 continuation line under-indented for visual indent
./cowrie/commands/netstat.py:99:17: E128 continuation line under-indented for visual indent
4     E128 continuation line under-indented for visual indent
4

* flake8 E1 cowrie/commands/ls.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/ls.py"
./cowrie/commands/ls.py:182:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ls.py:183:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ls.py:184:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ls.py:185:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ls.py:186:17: E128 continuation line under-indented for visual indent
./cowrie/commands/ls.py:187:17: E128 continuation line under-indented for visual indent
6     E128 continuation line under-indented for visual indent
6

* flake8 E1 cowrie/commands/__init__.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*commands/__init__.py"
./cowrie/commands/__init__.py:41:5: E123 closing bracket does not match indentation of opening bracket's line
1     E123 closing bracket does not match indentation of opening bracket's line
1

* flake8 E1 cowrie/commands/cat.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*cat.py"
./cowrie/commands/cat.py:105:1: E122 continuation line missing indentation or outdented
1     E122 continuation line missing indentation or outdented
1

* flake8 E1 cowrie/commands/tar.py

* flake8 E1 cowrie/commands/sudo.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*sudo.py"
./cowrie/commands/sudo.py:82:1: E122 continuation line missing indentation or outdented
./cowrie/commands/sudo.py:122:17: E128 continuation line under-indented for visual indent
1     E122 continuation line missing indentation or outdented
1     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/commands/curl.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*curl.py"
./cowrie/commands/curl.py:38:17: E128 continuation line under-indented for visual indent
./cowrie/commands/curl.py:83:21: E128 continuation line under-indented for visual indent
./cowrie/commands/curl.py:377:13: E128 continuation line under-indented for visual indent
./cowrie/commands/curl.py:412:21: E128 continuation line under-indented for visual indent
./cowrie/commands/curl.py:459:17: E128 continuation line under-indented for visual indent
5     E128 continuation line under-indented for visual indent
5

* flake8 E1 cowrie/commands/service.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*service.py"
./cowrie/commands/service.py:28:10: E121 continuation line under-indented for hanging indent
1     E121 continuation line under-indented for hanging indent
1

* flake8 E1 cowrie/ssh/connection.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*connection.py"
./cowrie/ssh/connection.py:60:17: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/ssh/factory.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*factory.py"
./cowrie/ssh/factory.py:34:9: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/ssh/factory.py:62:11: E121 continuation line under-indented for hanging indent
./cowrie/ssh/factory.py:65:11: E121 continuation line under-indented for hanging indent
./cowrie/ssh/factory.py:119:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/factory.py:120:13: E128 continuation line under-indented for visual indent
2     E121 continuation line under-indented for hanging indent
1     E123 closing bracket does not match indentation of opening bracket's line
2     E128 continuation line under-indented for visual indent
5

* flake8 E1 cowrie/ssh/channel.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*channel.py"
./cowrie/ssh/channel.py:56:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:69:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:71:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:72:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:81:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:82:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:83:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:84:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:98:11: E127 continuation line over-indented for visual indent
./cowrie/ssh/channel.py:105:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/channel.py:119:17: E128 continuation line under-indented for visual indent
1     E127 continuation line over-indented for visual indent
10    E128 continuation line under-indented for visual indent
11

* flake8 E1 cowrie/ssh/userauth.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*userauth.py"
./cowrie/ssh/userauth.py:102:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/userauth.py:115:21: E126 continuation line over-indented for hanging indent
./cowrie/ssh/userauth.py:120:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/userauth.py:122:13: E128 continuation line under-indented for visual indent
1     E126 continuation line over-indented for hanging indent
3     E128 continuation line under-indented for visual indent
4

* flake8 E1 cowrie/ssh/forwarding.py

flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*forwarding.py"
./cowrie/ssh/forwarding.py:23:9: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:24:9: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:25:9: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:47:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:52:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:74:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:79:17: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:82:12: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:114:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:115:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/forwarding.py:149:13: E128 continuation line under-indented for visual indent
11    E128 continuation line under-indented for visual indent
11

* flake8 E1 cowrie/ssh/transport.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*transport.py"
./cowrie/ssh/transport.py:56:12: E128 continuation line under-indented for visual indent
./cowrie/ssh/transport.py:57:12: E128 continuation line under-indented for visual indent
./cowrie/ssh/transport.py:58:12: E128 continuation line under-indented for visual indent
./cowrie/ssh/transport.py:59:12: E128 continuation line under-indented for visual indent
./cowrie/ssh/transport.py:213:13: E128 continuation line under-indented for visual indent
./cowrie/ssh/transport.py:214:13: E128 continuation line under-indented for visual indent
6     E128 continuation line under-indented for visual indent
6

* flake8 E1 cowrie/output/mysql.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*mysql.py"
./cowrie/output/mysql.py:73:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:131:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:132:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:133:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:134:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:138:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:139:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:140:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:141:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:145:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:146:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:150:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:151:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:152:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:156:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:157:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:158:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:162:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:163:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:164:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:165:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:169:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:170:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:171:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:172:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:176:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:177:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:178:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:179:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:183:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:184:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:185:17: E128 continuation line under-indented for visual indent
./cowrie/output/mysql.py:186:17: E128 continuation line under-indented for visual indent
33    E128 continuation line under-indented for visual indent
33

* flake8 E1 cowrie/output/hpfeeds.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*hpfeeds.py"
./cowrie/output/hpfeeds.py:199:21: E128 continuation line under-indented for visual indent
./cowrie/output/hpfeeds.py:203:21: E128 continuation line under-indented for visual indent
./cowrie/output/hpfeeds.py:212:34: E128 continuation line under-indented for visual indent
./cowrie/output/hpfeeds.py:215:34: E126 continuation line over-indented for hanging indent
./cowrie/output/hpfeeds.py:298:17: E128 continuation line under-indented for visual indent
./cowrie/output/hpfeeds.py:299:17: E128 continuation line under-indented for visual indent
1     E126 continuation line over-indented for hanging indent
5     E128 continuation line under-indented for visual indent
6

* flake8 E1 cowrie/output/hpfeeds3.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*hpfeeds3.py"
./cowrie/output/hpfeeds3.py:68:17: E128 continuation line under-indented for visual indent
./cowrie/output/hpfeeds3.py:69:17: E128 continuation line under-indented for visual indent
2     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/output/s3.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*s3.py"
./cowrie/output/s3.py:31:11: E111 indentation is not a multiple of four
1     E111 indentation is not a multiple of four
1

* flake8 E1 cowrie/output/malshare.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*malshare.py"
./cowrie/output/malshare.py:97:21: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/output/sqlite.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*sqlite.py"
./cowrie/output/sqlite.py:35:21: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:89:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:90:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:91:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:92:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:96:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:97:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:98:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:99:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:103:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:104:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:105:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:106:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:110:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:111:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:112:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:113:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:117:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:118:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:122:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:123:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:124:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:125:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:129:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:130:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:131:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:132:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:136:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:137:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:138:17: E128 continuation line under-indented for visual indent
./cowrie/output/sqlite.py:139:17: E128 continuation line under-indented for visual indent
31    E128 continuation line under-indented for visual indent
31

* flake8 E1 cowrie/output/influx.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*influx.py"
./cowrie/output/influx.py:145:17: E123 closing bracket does not match indentation of opening bracket's line
./cowrie/output/influx.py:150:17: E123 closing bracket does not match indentation of opening bracket's line
2     E123 closing bracket does not match indentation of opening bracket's line
2

* flake8 E1 cowrie/output/cuckoo.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*cuckoo.py"
./cowrie/output/cuckoo.py:106:17: E128 continuation line under-indented for visual indent
./cowrie/output/cuckoo.py:107:17: E128 continuation line under-indented for visual indent
./cowrie/output/cuckoo.py:108:17: E128 continuation line under-indented for visual indent
./cowrie/output/cuckoo.py:124:29: E126 continuation line over-indented for hanging indent
./cowrie/output/cuckoo.py:126:25: E126 continuation line over-indented for hanging indent
./cowrie/output/cuckoo.py:127:25: E126 continuation line over-indented for hanging indent
./cowrie/output/cuckoo.py:144:29: E126 continuation line over-indented for hanging indent
./cowrie/output/cuckoo.py:146:25: E126 continuation line over-indented for hanging indent
./cowrie/output/cuckoo.py:147:25: E126 continuation line over-indented for hanging indent
6     E126 continuation line over-indented for hanging indent
3     E128 continuation line under-indented for visual indent
9

* flake8 E1 cowrie/output/dshield.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*dshield.py"
./cowrie/output/dshield.py:84:17: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:89:13: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:92:19: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:99:33: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py💯33: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:101:33: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:102:33: E128 continuation line under-indented for visual indent
./cowrie/output/dshield.py:103:33: E128 continuation line under-indented for visual indent
8     E128 continuation line under-indented for visual indent
8

* flake8 E1 cowrie/shell/honeypot.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/honeypot.py"
./cowrie/shell/honeypot.py:489:17: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/shell/fs.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/fs.py"
./cowrie/shell/fs.py:177:29: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:236:33: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:240:33: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:286:13: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:306:13: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:379:21: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:380:21: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:562:17: E128 continuation line under-indented for visual indent
./cowrie/shell/fs.py:570:13: E128 continuation line under-indented for visual indent
9     E128 continuation line under-indented for visual indent
9

* flake8 E1 cowrie/shell/filetransfer.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/filetransfer.py"
./cowrie/shell/filetransfer.py:192:11: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/shell/pwd.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/pwd.py"
./cowrie/shell/pwd.py:49:13: E128 continuation line under-indented for visual indent
./cowrie/shell/pwd.py:132:13: E128 continuation line under-indented for visual indent
2     E128 continuation line under-indented for visual indent
2

* flake8 E1 cowrie/shell/session.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/session.py"
./cowrie/shell/session.py:68:13: E128 continuation line under-indented for visual indent
1     E128 continuation line under-indented for visual indent
1

* flake8 E1 cowrie/shell/protocol.py

Before:
flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --select=E1 --statistics --filename="*shell/protocol.py"
./cowrie/shell/protocol.py:57:21: E128 continuation line under-indented for visual indent
./cowrie/shell/protocol.py:179:21: E128 continuation line under-indented for visual indent
./cowrie/shell/protocol.py:185:13: E128 continuation line under-indented for visual indent
./cowrie/shell/protocol.py:321:13: E123 closing bracket does not match indentation of opening bracket's line
1     E123 closing bracket does not match indentation of opening bracket's line
3     E128 continuation line under-indented for visual indent
4
2018-06-28 00:06:00 +04:00
330e284fb1 2 separate imports 2018-06-27 12:36:04 +04:00
4f62c56341 py3 fixes for proxy 2018-06-27 12:35:37 +04:00
786d09e29d Added Elasticsearch Pipeline (#788) 2018-06-24 10:46:29 +04:00
b10921fa45 syntax error 2018-06-23 17:14:59 +00:00
2611a98355 update 2018-06-23 17:13:55 +00:00
55a083b018 Log version earlier. Log KEX attributes in fingerprint emssage 2018-06-23 17:12:55 +00:00
558bd2a6e0 document pre-post login banner 2018-06-23 17:06:51 +00:00
080985c4fc copy openssh behavior on 1.x verison string 2018-06-23 16:51:31 +00:00
291ed78d85 py3 mention 2018-06-22 11:50:45 +00:00
047aa63724 dont' use 'basestring'. 2018-06-22 09:33:44 +00:00
de0b1f93ba optionally accept bytes to write() 2018-06-22 09:33:23 +00:00
528907e0fe Ignore E3xx 2018-06-22 09:27:34 +00:00
d50617b73b ftpget doesn't need 'object' 2018-06-22 09:22:31 +00:00
fccc7f0044 Move bytes->string conversion from honeypot.py to protocol.py 2018-06-22 09:16:24 +00:00
84cd89695f remove superfluous spaces 2018-06-22 07:33:57 +00:00
d686accd33 disable Twistedchecker 2018-06-22 07:10:07 +00:00
eb8a12b598 skip pep8 2018-06-22 06:49:06 +00:00
456ca59eda add current slack join link 2018-06-21 14:43:48 +04:00
907569c8e8 Merge branch 'master' of http://www.github.com/micheloosterhof/cowrie 2018-06-21 14:32:10 +04:00
23dcbbeee4 ssh client fingerprint 2018-06-21 14:30:32 +04:00
0957606546 whitespace for flake8 2018-06-20 19:38:50 +00:00
34c8d98ffc Merge branch 'master' of https://github.com/micheloosterhof/cowrie 2018-06-20 19:26:53 +00:00
20f44cdcff remove tabs 2018-06-20 19:26:35 +00:00
12777744f1 remove trailing whitespace 2018-06-20 23:17:33 +04:00
28245a969b more checking with twistedchecker 2018-06-20 23:17:25 +04:00
e3c47a3be6 wip 2018-06-20 23:09:17 +04:00
bb6827cbd4 Merge branch 'master' of https://github.com/micheloosterhof/cowrie 2018-06-19 20:14:11 +00:00
a9bb5db866 fakeoutfile should be safeoutfile 2018-06-19 20:13:32 +00:00
09302626da fixes 2018-06-19 11:30:17 +04:00
75024a095f i.path -> filepath 2018-06-18 18:17:07 +04:00
415a40a74d fix EXTENDED_DATA_STDERR 2018-06-18 18:14:39 +04:00
8c1f385451 UNIQUECHAN not defined. write to COWRIECHAN 2018-06-18 18:01:40 +04:00
8f3bf5031e add log import 2018-06-18 18:00:05 +04:00
6a8c6c872e fix import of Failure() 2018-06-18 17:56:18 +04:00
8794fb5fea fix import 2018-06-18 17:54:51 +04:00
c5fb8b1345 name -> self.name 2018-06-18 17:52:06 +04:00
f51e885c4e define IsADirectory exception and formatting 2018-06-18 17:49:53 +04:00
a0b20f565d Merge branch 'master' of http://www.github.com/micheloosterhof/cowrie 2018-06-18 17:05:20 +04:00
088830e635 kafka 2018-06-18 17:05:12 +04:00